qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function
Date: Thu, 13 Jul 2017 06:43:48 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

On 07/13/2017 06:22 AM, Markus Armbruster wrote:
>>>> I can take this through my tree once PATCH 4 got some R-by from PC
>>>> paintainers.  Whom you again neglected to cc; I just did that for you.
>>>> I'll be happy to touch up minor issues like the ones I pointed out for
>>>> v4.
>>>
>>> Thanks for CCing them. I keep assuming git send-email will CC from the
>>> suggested-by line, but apparently not.
>>
>> It will, if you add 'git config sendemail.cccmd
>> "/path/to/scripts/get_maintainer.pl --nogit-fallback --noroles"'
> 
> Misunderstanding?  Your bit of configuration automates cc'ing
> maintainers.  Alistair was wondering about Suggested-by lines.

Indeed. Unless someone submits a patch to upstream git, right now there
is only a finite set of 'Tag: <address@hidden>' that git will
automatically cc (including Signed-off-by: and CC:, but excluding
Suggested-by:).  It might be nice if git could add a knob to select
which Tag:s are important (or just relax its regular expression to send
CC:s to everything that looks like a Tag:).  But for now, adding ccs to
suggested-by requires manual effort.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]