Re: [Qemu-devel] [PATCH v4 12/18] crypto: introduce some common functions for af_alg backend

[long mike]

2017-07-11 20:28 GMT+08:00 Daniel P. Berrange <address@hidden>:
> On Tue, Jul 04, 2017 at 04:57:04PM +0800, Longpeng(Mike) wrote:
>> The AF_ALG socket family is the userspace interface for linux
>> crypto API, this patch adds af_alg family support and some common
>> functions for af_alg backend. It'll be used by afalg-backend crypto
>> latter.
>>
>> Signed-off-by: Longpeng(Mike) <address@hidden>
>> ---
>>  configure            |  22 ++++++++++
>>  crypto/Makefile.objs |   1 +
>>  crypto/afalg.c       | 118 
>> +++++++++++++++++++++++++++++++++++++++++++++++++++
>>  crypto/afalgpriv.h   |  55 ++++++++++++++++++++++++
>>  4 files changed, 196 insertions(+)
>>  create mode 100644 crypto/afalg.c
>>  create mode 100644 crypto/afalgpriv.h
>>
>> diff --git a/crypto/afalgpriv.h b/crypto/afalgpriv.h
>> new file mode 100644
>> index 0000000..d21160c
>> --- /dev/null
>> +++ b/crypto/afalgpriv.h
>> @@ -0,0 +1,55 @@
>
>> +
>> +struct QCryptoAFAlg {
>> +    int tfmfd;
>> +    int opfd;
>> +    char *name;
>
> What actually uses this 'name' field ?  I'm not seing anything in the
> patch series that ever reads it, once set. So can we just delete it
> perhaps ?
>
Hi Daniel,

I'm on vacation so I can just replay messages through my personal
email account these days.

Yes, the 'name' field isn't used by others, it just for debug, it's
convenient.  But if you don't like it, I'll remove it.

PS: I'll have a close look at your other suggestions and send v5 as
soon as possible. Thanks :)

Reards,
Longpeng

>> +    struct msghdr *msg;
>> +    struct cmsghdr *cmsg;
>> +};
>
> Regards,
> Daniel
> --
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



-- 
Reards,
Longpeng