[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2] target/i386: Fix BLSR and BLSI
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH v2] target/i386: Fix BLSR and BLSI |
Date: |
Wed, 12 Jul 2017 09:29:02 -1000 |
The implementation of these two instructions was swapped.
At the same time, unify the setup of eflags for the insn group.
Reported-by: Ricardo Ribalda Delgado <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target/i386/translate.c | 26 +++++++++-----------------
1 file changed, 9 insertions(+), 17 deletions(-)
diff --git a/target/i386/translate.c b/target/i386/translate.c
index 9d5f1c3..69d3787 100644
--- a/target/i386/translate.c
+++ b/target/i386/translate.c
@@ -4031,34 +4031,26 @@ static void gen_sse(CPUX86State *env, DisasContext *s,
int b,
ot = mo_64_32(s->dflag);
gen_ldst_modrm(env, s, modrm, ot, OR_TMP0, 0);
+ tcg_gen_mov_tl(cpu_cc_src, cpu_T0);
switch (reg & 7) {
case 1: /* blsr By,Ey */
- tcg_gen_neg_tl(cpu_T1, cpu_T0);
+ tcg_gen_subi_tl(cpu_T1, cpu_T0, 1);
tcg_gen_and_tl(cpu_T0, cpu_T0, cpu_T1);
- gen_op_mov_reg_v(ot, s->vex_v, cpu_T0);
- gen_op_update2_cc();
- set_cc_op(s, CC_OP_BMILGB + ot);
break;
-
case 2: /* blsmsk By,Ey */
- tcg_gen_mov_tl(cpu_cc_src, cpu_T0);
- tcg_gen_subi_tl(cpu_T0, cpu_T0, 1);
- tcg_gen_xor_tl(cpu_T0, cpu_T0, cpu_cc_src);
- tcg_gen_mov_tl(cpu_cc_dst, cpu_T0);
- set_cc_op(s, CC_OP_BMILGB + ot);
+ tcg_gen_subi_tl(cpu_T1, cpu_T0, 1);
+ tcg_gen_xor_tl(cpu_T0, cpu_T0, cpu_T1);
break;
-
case 3: /* blsi By, Ey */
- tcg_gen_mov_tl(cpu_cc_src, cpu_T0);
- tcg_gen_subi_tl(cpu_T0, cpu_T0, 1);
- tcg_gen_and_tl(cpu_T0, cpu_T0, cpu_cc_src);
- tcg_gen_mov_tl(cpu_cc_dst, cpu_T0);
- set_cc_op(s, CC_OP_BMILGB + ot);
+ tcg_gen_neg_tl(cpu_T1, cpu_T0);
+ tcg_gen_and_tl(cpu_T0, cpu_T0, cpu_T1);
break;
-
default:
goto unknown_op;
}
+ tcg_gen_mov_tl(cpu_cc_dst, cpu_T0);
+ gen_op_mov_reg_v(ot, s->vex_v, cpu_T0);
+ set_cc_op(s, CC_OP_BMILGB + ot);
break;
default:
--
2.9.4
- [Qemu-devel] [PATCH 0/2] target/i386: Implement all TBM instructions, Richard Henderson, 2017/07/11
- [Qemu-devel] [PATCH 2/2] target/i386: Implement all TBM instructions, Richard Henderson, 2017/07/11
- [Qemu-devel] [PATCH 1/2] target/i386: Decode AMD XOP prefix, Richard Henderson, 2017/07/11
- Re: [Qemu-devel] [PATCH 0/2] target/i386: Implement all TBM instructions, Richard Henderson, 2017/07/12
- Re: [Qemu-devel] [PATCH 0/2] target/i386: Implement all TBM instructions, Ricardo Ribalda Delgado, 2017/07/12
- Re: [Qemu-devel] [PATCH 0/2] target/i386: Implement all TBM instructions, Richard Henderson, 2017/07/12
- [Qemu-devel] [PATCH] target/i386: Fix BLSR and BLSI, Richard Henderson, 2017/07/12
- Re: [Qemu-devel] [PATCH] target/i386: Fix BLSR and BLSI, Ricardo Ribalda Delgado, 2017/07/12
- Re: [Qemu-devel] [PATCH] target/i386: Fix BLSR and BLSI, Richard Henderson, 2017/07/12
- Re: [Qemu-devel] [PATCH] target/i386: Fix BLSR and BLSI, Ricardo Ribalda Delgado, 2017/07/12
- [Qemu-devel] [PATCH v2] target/i386: Fix BLSR and BLSI,
Richard Henderson <=
- Re: [Qemu-devel] [PATCH v2] target/i386: Fix BLSR and BLSI, Ricardo Ribalda Delgado, 2017/07/13
- Re: [Qemu-devel] [PATCH v2] target/i386: Fix BLSR and BLSI, Ricardo Ribalda Delgado, 2017/07/13
- Re: [Qemu-devel] [PATCH v2] target/i386: Fix BLSR and BLSI, Ricardo Ribalda Delgado, 2017/07/13