[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/22] cputlb: bring back tlb_flush_count under
|
From: |
Emilio G. Cota |
|
Subject: |
Re: [Qemu-devel] [PATCH 03/22] cputlb: bring back tlb_flush_count under !TLB_DEBUG |
|
Date: |
Sun, 9 Jul 2017 17:20:20 -0400 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Sun, Jul 09, 2017 at 16:56:23 -0400, Emilio G. Cota wrote:
> On Sun, Jul 09, 2017 at 10:00:01 -1000, Richard Henderson wrote:
> > On 07/08/2017 09:49 PM, Emilio G. Cota wrote:
> > >+ atomic_set(&env->tlb_flush_count, env->tlb_flush_count + 1);
> >
> > Want atomic_read here, so they're all the same.
>
> It's not needed. Note that this thread is the only one ever writing
> to env->tlb_flush_count, so the thread can read this value without
> atomic accesses.
>
> You'll see this pattern all across the patchset.
We already have this kind of pattern in QEMU. See this patch and
related discussion:
https://patchwork.kernel.org/patch/9358939/
E.
- Re: [Qemu-devel] [PATCH 18/22] tcg: define TCG_HIGHWATER, (continued)
- [Qemu-devel] [PATCH 13/22] tcg: take tb_ctx out of TCGContext, Emilio G. Cota, 2017/07/09
- [Qemu-devel] [PATCH 10/22] exec-all: move tb->invalid to the end of the struct, Emilio G. Cota, 2017/07/09
- [Qemu-devel] [PATCH 20/22] tcg: dynamically allocate from code_gen_buffer using equally-sized regions, Emilio G. Cota, 2017/07/09
- [Qemu-devel] [PATCH 03/22] cputlb: bring back tlb_flush_count under !TLB_DEBUG, Emilio G. Cota, 2017/07/09
- Re: [Qemu-devel] [PATCH 03/22] cputlb: bring back tlb_flush_count under !TLB_DEBUG, Alex Bennée, 2017/07/12
- [Qemu-devel] [PATCH 15/22] gen-icount: fold exitreq_label into TCGContext, Emilio G. Cota, 2017/07/09
- [Qemu-devel] [PATCH 05/22] exec-all: fix typos in TranslationBlock's documentation, Emilio G. Cota, 2017/07/09
- [Qemu-devel] [PATCH 19/22] tcg: introduce tcg_context_clone, Emilio G. Cota, 2017/07/09