[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 0/2] qom: Fix ambiguous path detection when ambiguou
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH 0/2] qom: Fix ambiguous path detection when ambiguous=NULL |
Date: |
Fri, 7 Jul 2017 18:30:50 -0300 |
object_resolve_path*() ambiguous path detection breaks when
ambiguous==NULL and the object tree have 3 objects of the same type and
only 2 of them are under the same parent. e.g.:
/container/obj1 (TYPE_FOO)
/container/obj2 (TYPE_FOO)
/obj2 (TYPE_FOO)
With the above tree, object_resolve_path_type("", TYPE_FOO, NULL) will
incorrectly return /obj2, because the search inside "/container" will
return NULL, and the match at "/obj2" won't be detected as ambiguous.
Fix that by always calling object_resolve_partial_path() with a non-NULL
ambiguous parameter.
Test case included.
Reported-by: Igor Mammedov <address@hidden>
Cc: Mark Cave-Ayland <address@hidden>
Eduardo Habkost (2):
tests: Test case for object_resolve_path*()
qom: Fix ambiguous path detection when ambiguous=NULL
qom/object.c | 17 ++++++++---------
tests/check-qom-proplist.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 52 insertions(+), 9 deletions(-)
--
2.9.4
- [Qemu-devel] [PATCH 0/2] qom: Fix ambiguous path detection when ambiguous=NULL,
Eduardo Habkost <=
[Qemu-devel] [PATCH 2/2] qom: Fix ambiguous path detection when ambiguous=NULL, Eduardo Habkost, 2017/07/07
Re: [Qemu-devel] [PATCH 0/2] qom: Fix ambiguous path detection when ambiguous=NULL, Mark Cave-Ayland, 2017/07/10
Re: [Qemu-devel] [PATCH 0/2] qom: Fix ambiguous path detection when ambiguous=NULL, Eduardo Habkost, 2017/07/10