[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] scripts: use build_ prefix for string no
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] scripts: use build_ prefix for string not piped through cgen() |
Date: |
Thu, 06 Jul 2017 10:23:05 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> Suggested by Markus Armbruster:
Replacing the line above with ...
> The gen_ prefix is awkward. Generated C should go through cgen()
> exactly once (see commit 1f9a7a1). The common way to get this wrong is
> passing a foo=gen_foo() keyword argument to mcgen(). I'd like us to
> adopt a naming convention where gen_ means "something that's been piped
> through cgen(), and thus must not be passed to cgen() or mcgen()".
> Requires renaming gen_params(), gen_marshal_proto() and
> gen_event_send_proto().
Suggested-by: Markus Armbruster <address@hidden>
> Signed-off-by: Marc-André Lureau <address@hidden>
Applied, thanks!
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v2 1/2] scripts: use build_ prefix for string not piped through cgen(),
Markus Armbruster <=