[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/5] qemu-iotests: test savevm/loadvm iothread (
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 0/5] qemu-iotests: test savevm/loadvm iothread (and make it work!) |
Date: |
Wed, 5 Jul 2017 13:55:17 +0100 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Mon, Jun 19, 2017 at 03:26:56PM +0300, Pavel Butsykin wrote:
> On 15.06.2017 19:38, Stefan Hajnoczi wrote:
> > This series extends qemu-iotests 068 to also run with iothread enabled.
> > Doing
> > so was harder than expected because:
> >
> > 1. ioeventfd is disabled without -M accel=kvm even though it should work
> > 2. loadvm still has an iothread bug
> >
> > Instead of adding a ./check -iothread option I decided to always run the
> > test.
> > Kevin recently recommended this approach; the advantage is that iothread
> > *will*
> > always be tested iothread mode whereas people won't run ./check -iothread.
>
> Why not just add -iothread option in check-block.sh? We can do an
> additional run with -iothread, as it is done for different block
> formats.
>
> Because all the test cases already exist, we can just reuse them.
From the email:
"the advantage is that iothread *will* always be tested iothread mode
whereas people won't run ./check -iothread"
Both approaches have pros and cons.
If we decide to use ./check -iothread then it's necessary to figure out
which tests -iothread even applies to. Tests that use qemu-img/qemu-io
do not use iothread. Only tests that launch QEMU can take advantage of
iothread today.
Stefan
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH 0/5] qemu-iotests: test savevm/loadvm iothread (and make it work!),
Stefan Hajnoczi <=