[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/7] s390x: fix error propagation in kvm-flic's
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH 3/7] s390x: fix error propagation in kvm-flic's realize |
Date: |
Tue, 4 Jul 2017 16:31:03 +0200 |
On Tue, 4 Jul 2017 16:07:55 +0200
Christian Borntraeger <address@hidden> wrote:
> From: Halil Pasic <address@hidden>
>
> From the moment it was introduced by commit a2875e6f98 ("s390x/kvm:
> implement floating-interrupt controller device", 2013-07-16) the kvm-flic
> is not making realize fail properly in case it's impossible to create the
> KVM device which basically serves as a backend and is absolutely
> essential for having an operational kvm-flic.
>
> Let's fix this by making sure we do proper error propagation in realize.
>
> Signed-off-by: Halil Pasic <address@hidden>
> Fixes: a2875e6f98 "s390x/kvm: implement floating-interrupt controller device"
> Reviewed-by: Dong Jia Shi <address@hidden>
> Reviewed-by: Yi Min Zhao <address@hidden>
> Signed-off-by: Christian Borntraeger <address@hidden>
> ---
> hw/intc/s390_flic_kvm.c | 14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
(...)
> cd.type = KVM_DEV_TYPE_FLIC;
> ret = kvm_vm_ioctl(kvm_state, KVM_CREATE_DEVICE, &cd);
> if (ret < 0) {
> - trace_flic_create_device(errno);
> - return;
> + error_setg_errno(&errp_local, errno, "Creating the KVM device
> failed");
> + trace_flic_no_device_api(errno);
Err... this should still be trace_flic_create_device(), no?
> + goto fail;
> }
> flic_state->fd = cd.fd;
- Re: [Qemu-devel] [PATCH 2/7] s390x/3270: fix instruction interception handler, (continued)
- [Qemu-devel] [PATCH 7/7] virtio-scsi-ccw: use ioeventfd even when KVM is disabled, Christian Borntraeger, 2017/07/04
- [Qemu-devel] [PATCH 4/7] s390x: fix realize inheritance for kvm-flic, Christian Borntraeger, 2017/07/04
- Re: [Qemu-devel] [PATCH 4/7] s390x: fix realize inheritance for kvm-flic, Cornelia Huck, 2017/07/04
- Re: [Qemu-devel] [PATCH 4/7] s390x: fix realize inheritance for kvm-flic, Halil Pasic, 2017/07/04
- Re: [Qemu-devel] [PATCH 4/7] s390x: fix realize inheritance for kvm-flic, Christian Borntraeger, 2017/07/05
- Re: [Qemu-devel] [PATCH 4/7] s390x: fix realize inheritance for kvm-flic, Halil Pasic, 2017/07/05
- Re: [Qemu-devel] [PATCH 4/7] s390x: fix realize inheritance for kvm-flic, Cornelia Huck, 2017/07/05
- Re: [Qemu-devel] [PATCH 4/7] s390x: fix realize inheritance for kvm-flic, Cornelia Huck, 2017/07/05
[Qemu-devel] [PATCH 3/7] s390x: fix error propagation in kvm-flic's realize, Christian Borntraeger, 2017/07/04
- Re: [Qemu-devel] [PATCH 3/7] s390x: fix error propagation in kvm-flic's realize,
Cornelia Huck <=
- Re: [Qemu-devel] [PATCH 3/7] s390x: fix error propagation in kvm-flic's realize, Halil Pasic, 2017/07/04
- Re: [Qemu-devel] [PATCH 3/7] s390x: fix error propagation in kvm-flic's realize, Halil Pasic, 2017/07/04
- Re: [Qemu-devel] [PATCH 3/7] s390x: fix error propagation in kvm-flic's realize, Cornelia Huck, 2017/07/04
- Re: [Qemu-devel] [PATCH 3/7] s390x: fix error propagation in kvm-flic's realize, Christian Borntraeger, 2017/07/04
- [Qemu-devel] [PATCH 1/1] s390x: fixup for "fix error propagation in kvm-flic...", Halil Pasic, 2017/07/05
- Re: [Qemu-devel] [PATCH 1/1] s390x: fixup for "fix error propagation in kvm-flic...", Cornelia Huck, 2017/07/05
- Re: [Qemu-devel] [PATCH 1/1] s390x: fixup for "fix error propagation in kvm-flic...", Christian Borntraeger, 2017/07/05
- Re: [Qemu-devel] [PATCH 1/1] s390x: fixup for "fix error propagation in kvm-flic...", Halil Pasic, 2017/07/05
[Qemu-devel] [PATCH 6/7] s390x: return unavailable features via query-cpu-definitions, Christian Borntraeger, 2017/07/04