[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] throttle: move out function to reuse the co
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/6] throttle: move out function to reuse the code |
|
Date: |
Fri, 30 Jun 2017 15:34:47 +0200 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 29 Jun 2017 05:10:53 PM CEST, Pradeep Jagadeesh wrote:
> This patch move out the throttle code to util/throttle.c to maximize
> the reusability of the code.The same code is also used by fsdev.
>
> Signed-off-by: Pradeep Jagadeesh <address@hidden>
> index 659a410..ac4f221 100644
> --- a/include/qemu/throttle-options.h
> +++ b/include/qemu/throttle-options.h
> @@ -10,6 +10,8 @@
> #ifndef THROTTLE_OPTIONS_H
> #define THROTTLE_OPTIONS_H
>
> +#include "qmp-commands.h"
> +
Shouldn't this be qapi-types.h instead ?
Otherwise the patch looks fine.
Berto
- [Qemu-devel] [PATCH v6 0/6] fsdev: qmp interface for io throttling, Pradeep Jagadeesh, 2017/06/29
- [Qemu-devel] [PATCH v6 2/6] qmp: Create IOThrottle structure, Pradeep Jagadeesh, 2017/06/29
- [Qemu-devel] [PATCH v6 1/6] throttle: factor out duplicate code, Pradeep Jagadeesh, 2017/06/29
- [Qemu-devel] [PATCH v6 4/6] hmp: create a throttle initialization function, Pradeep Jagadeesh, 2017/06/29
- [Qemu-devel] [PATCH v6 5/6] fsdev: hmp interface for throttling, Pradeep Jagadeesh, 2017/06/29
- [Qemu-devel] [PATCH 3/6] throttle: move out function to reuse the code, Pradeep Jagadeesh, 2017/06/29
- Re: [Qemu-devel] [PATCH 3/6] throttle: move out function to reuse the code,
Alberto Garcia <=
- [Qemu-devel] [PATCH v6 6/6] fsdev: QMP interface for throttling, Pradeep Jagadeesh, 2017/06/29