[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] qemu-iotests: 068: extract _qemu() function
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 3/5] qemu-iotests: 068: extract _qemu() function |
Date: |
Wed, 28 Jun 2017 16:07:52 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 28.06.2017 um 16:02 hat Eric Blake geschrieben:
> On 06/28/2017 07:57 AM, Kevin Wolf wrote:
> > Am 27.06.2017 um 13:40 hat Eric Blake geschrieben:
> >> On 06/15/2017 11:38 AM, Stefan Hajnoczi wrote:
> >>> Avoid duplicating the QEMU command-line.
> >>>
> >>> Signed-off-by: Stefan Hajnoczi <address@hidden>
> >>> ---
> >>> tests/qemu-iotests/068 | 13 ++++++++-----
> >>> 1 file changed, 8 insertions(+), 5 deletions(-)
> >>>
> >>
> >>> +# Give qemu some time to boot before saving the VM state
> >>> +bash -c 'sleep 1; echo -e "savevm 0\nquit"' | _qemu
> >>
> >> Are we sure that 'bash' on PATH is the same as the /bin/bash running the
> >> script?
> >
> > Do we even need to explicitly call bash here? Doesn't this do the same
> > as far as this test case is concerned?
> >
> > ( sleep 1; echo "..." ) | _qemu
>
> Or save a process:
>
> { sleep 1; echo "..."; } | _qemu
Ah, I knew that something like this must work. I missed the semicolon...
Kevin
pgpxIEUEyXZ7b.pgp
Description: PGP signature
- Re: [Qemu-devel] [PATCH 1/5] virtio-pci: use ioeventfd even when KVM is disabled, (continued)
[Qemu-devel] [PATCH 4/5] qemu-iotests: 068: use -drive/-device instead of -hda, Stefan Hajnoczi, 2017/06/15
[Qemu-devel] [PATCH 5/5] qemu-iotests: 068: test iothread mode, Stefan Hajnoczi, 2017/06/15
Re: [Qemu-devel] [PATCH 0/5] qemu-iotests: test savevm/loadvm iothread (and make it work!), Stefan Hajnoczi, 2017/06/15
Re: [Qemu-devel] [PATCH 0/5] qemu-iotests: test savevm/loadvm iothread (and make it work!), Pavel Butsykin, 2017/06/19
Re: [Qemu-devel] [PATCH 0/5] qemu-iotests: test savevm/loadvm iothread (and make it work!), Kevin Wolf, 2017/06/19