qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/7] qdev: Introduce DEFINE_PROP_LINK


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 4/7] qdev: Introduce DEFINE_PROP_LINK
Date: Wed, 28 Jun 2017 15:38:35 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0


On 28/06/2017 14:48, Fam Zheng wrote:
> 
> It's implemented by creating a wrapper property that basically forwards
> operations to a QOM "link-FOO" property, which handles the check
> callback and flags. The feature that is missing from QOM is the dynamic
> child pointer which is done in the added code with the usual "offset"
> approach.

Would it be possible to add a ".create" field to PropertyInfo?  Then
there's no need to introduce the wrapper.

Also, I think _check and _flags can be always
qdev_prop_allow_set_link_before_realize and
OBJ_PROP_LINK_UNREF_ON_RELEASE for DEFINE_PROP_LINK.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]