Re: [Qemu-devel] [PATCH 0/8] VT-d: some enhancements on iotlb and tools

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/8] VT-d: some enhancements on iotlb and tools
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
1cf4f53 intel_iommu: implement mru list for iotlb
1ae1ddf intel_iommu: use access_flags for iotlb
bad3f74 intel_iommu: let iotlb size tunable
7da9464 intel_iommu: hmp: allow "-c" for "info iommu"
f2c8b10 intel_iommu: add iotlb/context cache statistics
e3a1765 intel_iommu: support "info iommu"
7bb834f hmp: add info iommu
096a817 intel_iommu: fix VTD_PAGE_MASK

=== OUTPUT BEGIN ===
Checking PATCH 1/8: intel_iommu: fix VTD_PAGE_MASK...
ERROR: Macros with complex values should be enclosed in parenthesis
#38: FILE: hw/i386/intel_iommu_internal.h:387:
+#define VTD_PAGE_MASK               ~(VTD_PAGE_SIZE - 1)

total: 1 errors, 0 warnings, 16 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/8: hmp: add info iommu...
WARNING: architecture specific defines should be avoided
#79: FILE: include/hw/iommu.h:1:
+#ifndef __HW_IOMMU_H__

total: 0 errors, 1 warnings, 63 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/8: intel_iommu: support "info iommu"...
Checking PATCH 4/8: intel_iommu: add iotlb/context cache statistics...
Checking PATCH 5/8: intel_iommu: hmp: allow "-c" for "info iommu"...
Checking PATCH 6/8: intel_iommu: let iotlb size tunable...
Checking PATCH 7/8: intel_iommu: use access_flags for iotlb...
Checking PATCH 8/8: intel_iommu: implement mru list for iotlb...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden