[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitm
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex |
|
Date: |
Mon, 26 Jun 2017 18:54:41 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 26/06/2017 18:07, Vladimir Sementsov-Ogievskiy wrote:
> HI!
>
> One question here, should not 'bdrv_undo_clear_dirty_bitmap' be under
> lock too?
Any call to dirty bitmap functions between bdrv_clear_dirty_bitmap and
bdrv_undo_clear_dirty_bitmap is problematic anyway, so
bdrv_clear_dirty_bitmap really only needs the lock in the !out case;
bdrv_undo_clear_dirty_bitmap is only called when out != NULL.
However, I agree it would be cleaner to add the lock there, too.
Paolo
- [Qemu-devel] [PATCH 09/19] throttle-groups: protect throttled requests with a CoMutex, (continued)
- [Qemu-devel] [PATCH 09/19] throttle-groups: protect throttled requests with a CoMutex, Paolo Bonzini, 2017/06/05
- [Qemu-devel] [PATCH 11/19] block: use Stat64 for wr_highest_offset, Paolo Bonzini, 2017/06/05
- [Qemu-devel] [PATCH 08/19] throttle-groups: do not use qemu_co_enter_next, Paolo Bonzini, 2017/06/05
- [Qemu-devel] [PATCH 12/19] block: access write_gen with atomics, Paolo Bonzini, 2017/06/05
- [Qemu-devel] [PATCH 13/19] block: protect tracked_requests and flush_queue with reqs_lock, Paolo Bonzini, 2017/06/05
- [Qemu-devel] [PATCH 10/19] util: add stats64 module, Paolo Bonzini, 2017/06/05
- [Qemu-devel] [PATCH 14/19] block: introduce dirty_bitmap_mutex, Paolo Bonzini, 2017/06/05
- [Qemu-devel] [PATCH 17/19] block: introduce block_account_one_io, Paolo Bonzini, 2017/06/05
- [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Paolo Bonzini, 2017/06/05
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Vladimir Sementsov-Ogievskiy, 2017/06/26
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Vladimir Sementsov-Ogievskiy, 2017/06/27
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Paolo Bonzini, 2017/06/27
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Vladimir Sementsov-Ogievskiy, 2017/06/27
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Paolo Bonzini, 2017/06/27
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Vladimir Sementsov-Ogievskiy, 2017/06/27
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Paolo Bonzini, 2017/06/27
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Vladimir Sementsov-Ogievskiy, 2017/06/27
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Paolo Bonzini, 2017/06/27
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Vladimir Sementsov-Ogievskiy, 2017/06/27
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Paolo Bonzini, 2017/06/27