[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/21] tests: add missing dependency to build
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [PATCH v2 01/21] tests: add missing dependency to build QTEST_QEMU_BINARY |
Date: |
Fri, 23 Jun 2017 15:27:13 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 06/21/2017 11:32 PM, Philippe Mathieu-Daudé wrote:
> This allow a one liner from fresh repository clone, i.e.:
>
> ./configure && make -j check-qtest-aarch64
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 77da9b7f4b..f7c8f3eddb 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -823,7 +823,7 @@ GCOV_OPTIONS = -n $(if $(V),-f,)
> # gtester tests, possibly with verbose output
>
> .PHONY: $(patsubst %, check-qtest-%, $(QTEST_TARGETS))
> -$(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%:
> $(check-qtest-y)
> +$(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%:
> subdir-%-softmmu $(check-qtest-y)
> $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,)
> $(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \
> QTEST_QEMU_IMG=qemu-img$(EXESUF) \
>
I'm on board, it's nice to have proper dependencies.
Reviewed-by: John Snow <address@hidden>
- [Qemu-devel] [PATCH v2 00/21] travis: speedup to reduce failures, Philippe Mathieu-Daudé, 2017/06/21
- [Qemu-devel] [PATCH v2 01/21] tests: add missing dependency to build QTEST_QEMU_BINARY, Philippe Mathieu-Daudé, 2017/06/21
- [Qemu-devel] [PATCH v2 02/21] travis: retry if llvm.org timeouts, Philippe Mathieu-Daudé, 2017/06/21
- [Qemu-devel] [PATCH v2 03/21] travis: install more library dependencies, Philippe Mathieu-Daudé, 2017/06/21
- [Qemu-devel] [PATCH v2 04/21] travis: install more library dependencies, Philippe Mathieu-Daudé, 2017/06/21
- [Qemu-devel] [PATCH v2 05/21] scripts/run-coverity-scan: Script to run Coverity Scan build, Philippe Mathieu-Daudé, 2017/06/21
- [Qemu-devel] [PATCH v2 07/21] travis: update sudo-enabled Trusty images, Philippe Mathieu-Daudé, 2017/06/21
- [Qemu-devel] [PATCH v2 06/21] travis: Add config to do a Coverity Scan upload, Philippe Mathieu-Daudé, 2017/06/21