[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3] live-block-ops.txt: Rename, rewrite, and imp

From: John Snow
Subject: Re: [Qemu-devel] [PATCH v3] live-block-ops.txt: Rename, rewrite, and improve it
Date: Thu, 22 Jun 2017 10:13:03 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0

On 06/22/2017 04:56 AM, Kashyap Chamarthy wrote:
> On Wed, Jun 21, 2017 at 06:49:02PM -0400, John Snow wrote:
> [...]
>>> * TODO (after feedback from John Snow):
>>>    - Eric Blake suggested to consider documenting incremental backup
>>>      policies as part of the section: "Live disk backup ---
>>>      `drive-backup` and `blockdev-backup`"
>> Perhaps it could be mentioned, but hopefully I've covered it in some
>> sufficient detail in the (now) docs/devel/bitmaps.md file; 
> Yes, that doc is very useful.  That was my precise thought.
>> I'm a little wary of duplicating efforts in this area, 
> I share your wariness.
>> but you've covered everything *else* in good detail here, so now my
>> file is the odd one out.
>> I will leave this up to you, really. Perhaps it could be paid some lip
>> service with a link to the other document? 
> Yes, I was thinking of this, too -- just link to the 'bitmaps' document.
> A quick side question here: Since upstream QEMU is converging onto
> Sphinx, and rST, hope you mind if I convert docs/devel/bitmaps.md into
> rST at somepoint, for consistency's sake.  I'll file a separate review,
> anyway for that.  In the long term, all / most other documents would
> also be converted.

Of course not. I chose bitmaps.md so that it would be nice to view from
the github interface while remaining nice to read in plaintext, but feel
free to convert it if we actually do standardize on Sphinx/rST.

If you can make the generated output look prettier than the github
rendering of the markdown I'll ACK it ;)

>> The detail in bitmaps.md is a little more verbose than the rest of
>> this file, so if you include it wholesale it'd dwarf the rest of this
>> document.
>> What do you think?
> Yes, I fully agree with your suggestion.  I will simply link to the
> detailed document you wrote, which I was thinking of anyhow.
> Thanks for your comments!
Sure. You could perhaps mention the different sync modes, including top,
none, full and incremental and urge readers to check out the bitmaps
document for detailed workings of the incremental mode.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]