Re: [Qemu-devel] [PATCH 12/15] tcg: remove inline definition of flush_icache_range()

[Paolo Bonzini]

On 21/06/2017 12:19, Yang Zhong wrote:
> Remove the inline defintion of flush_icache_range() in tcg/i386/tcg-target.h.
> add the flush_icache_range() implementation in tcg-target.inc.c for kvm/tcg
> and flush_icache_range() implementation in tcg-stub.c for disable-tcg.
> 
> Signed-off-by: Yang Zhong <address@hidden>

This is used even on KVM (by non-x86 architectures).  See
cpu_flush_icache_range.

You should move all flush_icache_range implementations to a separate
header file include/exec/icache.h.

Paolo
> ---
>  accel/stubs/tcg-stub.c    | 4 ++++
>  tcg/i386/tcg-target.h     | 5 ++---
>  tcg/i386/tcg-target.inc.c | 4 ++++
>  3 files changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c
> index 91625a8..85b0239 100644
> --- a/accel/stubs/tcg-stub.c
> +++ b/accel/stubs/tcg-stub.c
> @@ -83,6 +83,10 @@ void tcg_set_fpuc(CPUX86State *env)
>  {
>  }
>  
> +void flush_icache_range(uintptr_t start, uintptr_t stop)
> +{
> +}
> +
>  void cpu_loop_exit(CPUState *cpu)
>  {
>      abort();
> diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h
> index 73a15f7..7559cb8 100644
> --- a/tcg/i386/tcg-target.h
> +++ b/tcg/i386/tcg-target.h
> @@ -162,9 +162,8 @@ extern bool have_popcnt;
>  # define TCG_AREG0 TCG_REG_EBP
>  #endif
>  
> -static inline void flush_icache_range(uintptr_t start, uintptr_t stop)
> -{
> -}
> +void flush_icache_range(uintptr_t start, uintptr_t stop);
> +
>  
>  /* This defines the natural memory order supported by this
>   * architecture before guarantees made by various barrier
> diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c
> index 01e3b4e..6572efc 100644
> --- a/tcg/i386/tcg-target.inc.c
> +++ b/tcg/i386/tcg-target.inc.c
> @@ -2751,3 +2751,7 @@ void tcg_register_jit(void *buf, size_t buf_size)
>      tcg_register_jit_int(buf, buf_size, &debug_frame, sizeof(debug_frame));
>  }
>  #endif
> +
> +void flush_icache_range(uintptr_t start, uintptr_t stop)
> +{
> +}
>