[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 04/13] accel: introduce AccelState.global_pro
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v3 04/13] accel: introduce AccelState.global_props |
Date: |
Mon, 19 Jun 2017 13:17:39 -0300 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Mon, Jun 19, 2017 at 08:49:39PM +0800, Peter Xu wrote:
> Introduce this new field for the accelerator instances so that each
> specific accelerator in the future can register its own global
> properties to be used further by the system. It works just like how the
> old machine compatible properties do, but only tailored for
> accelerators.
>
> Use the newly exported register_compat_prop() to pass the accelerator
> global properties to the global_props list.
>
> Signed-off-by: Peter Xu <address@hidden>
As noted on other patches, I believe this should be
AccelClass::global_props (initialized statically in class_init)
instead of AccelState::global_props (built at runtime).
Otherwise, I don't see the benefit of the new field.
--
Eduardo
[Qemu-devel] [PATCH v3 07/13] tcg: use AccelState.global_props, Peter Xu, 2017/06/19