[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 12/13] migration: move skip_configuration out
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v3 12/13] migration: move skip_configuration out |
Date: |
Mon, 19 Jun 2017 17:56:29 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Peter Xu <address@hidden> wrote:
> It was in SaveState but now moved to MigrationState altogether, reverted
> its meaning, then renamed to "send_configuration". Again, using
> HW_COMPAT_2_3 for old PC/SPAPR machines, and accel_register_prop() for
> xen_init().
>
> Removing savevm_skip_configuration().
>
> Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
> - if (!savevm_state.skip_configuration || enforce_config_section()) {
> + if (migrate_get_current()->send_configuration ||
> + enforce_config_section()) {
> qemu_put_byte(f, QEMU_VM_CONFIGURATION);
> vmstate_save_state(f, &vmstate_configuration, &savevm_state, 0);
> }
It is a different problem, but this patch makes enforce_config_section
optional, no? We can get the same behaviour with this new option,
right?
Looking at the code, it is not clear to me if it is easier to put
enforce_config_option on top of this patch, or let things as they are.
Opinions?
Thanks, Juan.
- Re: [Qemu-devel] [PATCH v3 06/13] kvm: let kvm use AccelState.global_props, (continued)
- [Qemu-devel] [PATCH v3 07/13] tcg: use AccelState.global_props, Peter Xu, 2017/06/19
- [Qemu-devel] [PATCH v3 08/13] trace: add qdev_global_prop_apply, Peter Xu, 2017/06/19
- [Qemu-devel] [PATCH v3 09/13] migration: let MigrationState be a qdev, Peter Xu, 2017/06/19
- [Qemu-devel] [PATCH v3 10/13] migration: move global_state.optional out, Peter Xu, 2017/06/19
- [Qemu-devel] [PATCH v3 11/13] migration: move only_migratable to MigrationState, Peter Xu, 2017/06/19
- [Qemu-devel] [PATCH v3 12/13] migration: move skip_configuration out, Peter Xu, 2017/06/19
- Re: [Qemu-devel] [PATCH v3 12/13] migration: move skip_configuration out,
Juan Quintela <=
- [Qemu-devel] [PATCH v3 13/13] migration: move skip_section_footers, Peter Xu, 2017/06/19
- Re: [Qemu-devel] [PATCH v3 00/13] migration: objectify MigrationState, Juan Quintela, 2017/06/19