|
From: | Pavel Butsykin |
Subject: | Re: [Qemu-devel] [PATCH 0/5] qemu-iotests: test savevm/loadvm iothread (and make it work!) |
Date: | Mon, 19 Jun 2017 15:26:56 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 |
On 15.06.2017 19:38, Stefan Hajnoczi wrote:
This series extends qemu-iotests 068 to also run with iothread enabled. Doing so was harder than expected because: 1. ioeventfd is disabled without -M accel=kvm even though it should work 2. loadvm still has an iothread bug Instead of adding a ./check -iothread option I decided to always run the test. Kevin recently recommended this approach; the advantage is that iothread *will* always be tested iothread mode whereas people won't run ./check -iothread.
Why not just add -iothread option in check-block.sh? We can do an additional run with -iothread, as it is done for different block formats. Because all the test cases already exist, we can just reuse them.
Stefan Hajnoczi (5): virtio-pci: use ioeventfd even when KVM is disabled migration: hold AioContext lock for loadvm qemu_fclose() qemu-iotests: 068: extract _qemu() function qemu-iotests: 068: use -drive/-device instead of -hda qemu-iotests: 068: test iothread mode hw/virtio/virtio-pci.c | 2 +- migration/savevm.c | 2 +- tests/qemu-iotests/068 | 37 +++++++++++++++++++++++++------------ tests/qemu-iotests/068.out | 11 ++++++++++- 4 files changed, 37 insertions(+), 15 deletions(-)
[Prev in Thread] | Current Thread | [Next in Thread] |