[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] gen-icount: pass cpu_env as a parameter to
|
From: |
Emilio G. Cota |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] gen-icount: pass cpu_env as a parameter to gen_* inlines |
|
Date: |
Fri, 16 Jun 2017 14:50:56 -0400 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Jun 16, 2017 at 10:32:14 +0200, Paolo Bonzini wrote:
> On 16/06/2017 01:04, Emilio G. Cota wrote:
> > va = dest_gpr(ctx, ra);
> > if (ctx->tb->cflags & CF_USE_ICOUNT) {
> > - gen_io_start();
> > + gen_io_start(cpu_env);
> > gen_helper_load_pcc(va, cpu_env);
> > - gen_io_end();
> > + gen_io_start(cpu_env);
>
> Careful, looks like a cut-and-paste issue here.
Ouch, messed up the regex there -- thanks.
Fixed in the upcoming v2, which doesn't need to go through all this churn
and instead takes the value from tcg_ctx as Richard pointed out.
E.