[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH] virtio-blk: trace vdev so devices
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH] virtio-blk: trace vdev so devices can be distinguished |
|
Date: |
Fri, 16 Jun 2017 10:04:10 +0100 |
|
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Wed, Jun 14, 2017 at 10:29:30AM +0100, Stefan Hajnoczi wrote:
> It is hard to analyze trace logs with multiple virtio-blk devices
> because none of the trace events include the VirtIODevice *vdev.
>
> This patch adds vdev so it's clear which device a request is associated
> with.
>
> I considered using VirtIOBlock *s instead but VirtIODevice *vdev is more
> general and may be correlated with generic virtio trace events like
> virtio_set_status.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> hw/block/virtio-blk.c | 12 +++++++-----
> hw/block/trace-events | 10 +++++-----
> 2 files changed, 12 insertions(+), 10 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
signature.asc
Description: PGP signature