Re: [Qemu-devel] [PATCH v2 0/5] Fixes for TCG hangs

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 0/5] Fixes for TCG hangs
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
43fb9b8 target/arm: Exit after clearing interrupt mask
11693ca target/s390x: Exit after changing PSW mask
0a2e4e4 target/mips: Exit after enabling interrupts
c147794 target/alpha: Use tcg_gen_lookup_and_goto_ptr
53499be tcg: Refactor helper_lookup_tb_ptr

=== OUTPUT BEGIN ===
Checking PATCH 1/5: tcg: Refactor helper_lookup_tb_ptr...
Checking PATCH 2/5: target/alpha: Use tcg_gen_lookup_and_goto_ptr...
ERROR: return is not a function, parentheses are not required
#27: FILE: target/alpha/translate.c:464:
+    return ((ctx->tb->cflags & CF_LAST_IO)

total: 1 errors, 0 warnings, 66 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/5: target/mips: Exit after enabling interrupts...
Checking PATCH 4/5: target/s390x: Exit after changing PSW mask...
Checking PATCH 5/5: target/arm: Exit after clearing interrupt mask...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden