[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 5/7] pci: Replace pci_add_capability() with p
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 5/7] pci: Replace pci_add_capability() with pci_add_capability2() |
|
Date: |
Fri, 9 Jun 2017 10:53:53 -0300 |
|
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Fri, Jun 09, 2017 at 07:24:40PM +0800, Mao Zhongyi wrote:
> After the patch 'Make errp the last parameter of pci_add_capability()',
> pci_add_capability() and pci_add_capability2() now do exactly the same.
> So drop the wrapper pci_add_capability() of pci_add_capability2(), then
> replace the pci_add_capability() with pci_add_capability2() everywhere.
I would do the opposite, and keep pci_add_capability() only.
It's confusing to have a function named pci_add_capability2() if
pci_add_capability() doesn't exist anymore.
--
Eduardo
- [Qemu-devel] [PATCH v4 0/7] Convert to realize and cleanup, Mao Zhongyi, 2017/06/09
- [Qemu-devel] [PATCH v4 2/7] pci: Add comment for pci_add_capability2(), Mao Zhongyi, 2017/06/09
- [Qemu-devel] [PATCH v4 5/7] pci: Replace pci_add_capability() with pci_add_capability2(), Mao Zhongyi, 2017/06/09
- Re: [Qemu-devel] [PATCH v4 5/7] pci: Replace pci_add_capability() with pci_add_capability2(),
Eduardo Habkost <=
- [Qemu-devel] [PATCH v4 1/7] pci: Clean up error checking in pci_add_capability(), Mao Zhongyi, 2017/06/09
- [Qemu-devel] [PATCH v4 7/7] pci: Convert shpc_init() to Error, Mao Zhongyi, 2017/06/09
- [Qemu-devel] [PATCH v4 4/7] pci: Make errp the last parameter of pci_add_capability(), Mao Zhongyi, 2017/06/09
- [Qemu-devel] [PATCH v4 6/7] pci: Convert to realize, Mao Zhongyi, 2017/06/09
- [Qemu-devel] [PATCH v4 3/7] pci: Fix the return value checking, Mao Zhongyi, 2017/06/09