[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 02/41] object: fix potential leak in getters
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 02/41] object: fix potential leak in getters |
Date: |
Fri, 9 Jun 2017 15:46:46 +0200 |
From: Marc-André Lureau <address@hidden>
If the property is not of the requested type, the getters will leak a
QObject.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
qom/object.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index eb4bc92..c7b8079 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -1122,7 +1122,7 @@ char *object_property_get_str(Object *obj, const char
*name,
retval = g_strdup(qstring_get_str(qstring));
}
- QDECREF(qstring);
+ qobject_decref(ret);
return retval;
}
@@ -1183,7 +1183,7 @@ bool object_property_get_bool(Object *obj, const char
*name,
retval = qbool_get_bool(qbool);
}
- QDECREF(qbool);
+ qobject_decref(ret);
return retval;
}
@@ -1214,7 +1214,7 @@ int64_t object_property_get_int(Object *obj, const char
*name,
retval = qint_get_int(qint);
}
- QDECREF(qint);
+ qobject_decref(ret);
return retval;
}
--
2.7.5
- [Qemu-devel] [PULL 00/41] QAPI patches for 2017-06-09, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 02/41] object: fix potential leak in getters,
Markus Armbruster <=
- [Qemu-devel] [PULL 05/41] qapi: Clean up qobject_input_type_number() control flow, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 03/41] tests: Remove test cases for alternates of 'number' and 'int', Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 01/41] qdev: remove PropertyInfo.qtype field, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 09/41] qnum: add uint type, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 10/41] json: learn to parse uint64 numbers, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 12/41] object: add uint property setter/getter, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 11/41] qapi: update the qobject visitor to use QNUM_U64, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 20/41] isa: use get_uint() for "io-base", Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 16/41] qdev: wrap default property value in an union, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 04/41] tests: add more int/number ranges checks, Markus Armbruster, 2017/06/09