Re: [Qemu-devel] [PATCH RFC] block: add throttle block filter driver

[Eric Blake]

On 06/07/2017 11:06 AM, Manos Pitsidianakis wrote:
> On Wed, Jun 07, 2017 at 10:40:08AM -0500, Eric Blake wrote:
>> On 06/07/2017 08:06 AM, Manos Pitsidianakis wrote:
>>> This is part of my work for my GSOC project this summer.
>>>
>>> I am not sure if the count parameter in  bdrv_co_pwrite_zeros and
>>> bdrv_co_pdiscard refers to sectors or bytes.
>>
>> Both refer to byte counts.  (We're trying to get rid of as many
>> sector-based interfaces as possible, but it's slow going to make sure
>> the conversions are still accurate).
> 
> I see. Would changing the names in the BlockDriverState function
> signatures to reflect that be okay?

What names need changing?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature