Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

[Paolo Bonzini]

On 06/06/2017 18:30, Alistair Francis wrote:
>>
>> This is somehow confusing. I don't think it is worth having another
>> qemu_log_stderr() function rather than using error_report() but this very
>> call might deserve a comment explaining this unusual use. What do you think?
> 
> The problem with stderr is that this isn't an error. Some uses of QEMU
> (inside Eclipse for example) flag everything printed on stderr as red
> which confuses users that they are seeing an error when they really
> aren't.

But they are wrong.  Would it work for you to work around it, by making
QEMU use a client (connect) rather than a server (listen) socket?

> Also all the uses of this message that I have seen (there are probably
> others though) stops QEMU until the connection is made, which means it
> doesn't matter if it is mixed up in console output.

It may not mix up, but it would break programs expecting only console
output to be on stdout.

> I just think that this message to most users isn't helpful and they
> probably don't even read it, so printing to stderr seems like a bit
> much.

I would compare it with dd's output.  It goes to stderr even though it's
not an error.

Paolo