[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RISU PATCH v4 05/10] risu: paramterise send/receive fu
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [RISU PATCH v4 05/10] risu: paramterise send/receive functions |
Date: |
Tue, 6 Jun 2017 10:57:14 +0100 |
On 2 June 2017 at 17:08, Alex Bennée <address@hidden> wrote:
> This is a precursor to record/playback support. Instead of passing the
> socket fd we now pass helper functions for reading/writing and
> responding. This will allow us to do the rest of the record/playback
> cleanly outside of the main worker function.
>
> Signed-off-by: Alex Bennée <address@hidden>
> - } else if (!reginfo_is_eq(&master_ri, &apprentice_ri)) {
> + } else if (!reginfo_is_eq(&master_ri, &apprentice_ri)) {
> /* register mismatch */
> resp = 2;
> -
> - } else if (op == OP_TESTEND) {
> + } else if (op == OP_TESTEND) {
> resp = 1;
> - }
[etc]
If you're going to fix the indent can you put that in
its own patch, please? Much easier to review that way.
thanks
-- PMM
- [Qemu-devel] [RISU PATCH v4 00/10] record/replay patches, Alex Bennée, 2017/06/02
- [Qemu-devel] [RISU PATCH v4 02/10] build-all-archs: support cross building via docker, Alex Bennée, 2017/06/02
- [Qemu-devel] [RISU PATCH v4 01/10] .gitignore: ignore build directories, Alex Bennée, 2017/06/02
- [Qemu-devel] [RISU PATCH v4 04/10] risu: a bit more verbosity when running, Alex Bennée, 2017/06/02
- [Qemu-devel] [RISU PATCH v4 03/10] build-all-archs: support --static flag, Alex Bennée, 2017/06/02
- [Qemu-devel] [RISU PATCH v4 06/10] risu: add header to trace stream, Alex Bennée, 2017/06/02
- [Qemu-devel] [RISU PATCH v4 05/10] risu: paramterise send/receive functions, Alex Bennée, 2017/06/02
- Re: [Qemu-devel] [RISU PATCH v4 05/10] risu: paramterise send/receive functions,
Peter Maydell <=
- [Qemu-devel] [RISU PATCH v4 08/10] risu: add support compressed tracefiles, Alex Bennée, 2017/06/02
- [Qemu-devel] [RISU PATCH v4 07/10] risu: add simple trace and replay support, Alex Bennée, 2017/06/02
[Qemu-devel] [RISU PATCH v4 09/10] new: record_traces.sh helper script, Alex Bennée, 2017/06/02