Re: [Qemu-devel] [PATCH v2 0/6] tcg: move the tcg files into tcg/ subdirectory.

[Laurent Desnogues]

Hello,

On Wed, May 31, 2017 at 2:54 PM, Paolo Bonzini <address@hidden> wrote:
>
>
> On 31/05/2017 08:28, Yang Zhong wrote:
>> Move the tcg related files into tcg/ subdirectory, which will make
>> the code more clean in qemu. Next step, we will base on those changes
>> to disable tcg.
>
> You should also move cpu-exec.c, cpu-exec-common.c and cputlb.c.

The LICENSE file in tcg directory contains this:

---------------------------------------------------------------------
All the files in this directory and subdirectories are released under
a BSD like license (see header in each file). No other license is
accepted.
---------------------------------------------------------------------

All source files have an explicit BSD license except tcg-runtime.h
which has none and aarch64 files which are licensed under GPL.  So we
are already not following the rule expressed in LICENSE.

tcg-runtime.c is BSD
tci.c is GPL
translate-all.[ch] are GPL
translate-common.c is GPL
cpu-exec.c cpu-exec-common.c cputlb.c are GPL

I guess the LICENSE file has become obsolete and so should be removed
(and Fabrice Bellard should perhaps be let know about that just in
case).

Thanks,

Laurent

> Also, feel free to squash everything in a single patch.
> Thanks,
>
> Paolo
>
>> Yang Zhong (6):
>>   tcg: move tcg-runtime.c to tcg/ subdirectory
>>   tcg: move translate-all.c to tcg/ subdirectory
>>   tcg: move tcg header file
>>   tcg: move translate-common.c to tcg/ subdirectory
>>   tcg: move tci.c to tcg/ subdirectory
>>   tcg: change tcg related file's compile definition
>>
>>  Makefile.objs                                | 1 +
>>  Makefile.target                              | 8 ++------
>>  tcg/Makefile.objs                            | 2 ++
>>  tcg-runtime.c => tcg/tcg-runtime.c           | 0
>>  tci.c => tcg/tci.c                           | 0
>>  tcg/trace-events                             | 6 ++++++
>>  translate-all.c => tcg/translate-all.c       | 2 +-
>>  translate-all.h => tcg/translate-all.h       | 0
>>  translate-common.c => tcg/translate-common.c | 0
>>  trace-events                                 | 3 ---
>>  10 files changed, 12 insertions(+), 10 deletions(-)
>>  create mode 100644 tcg/Makefile.objs
>>  rename tcg-runtime.c => tcg/tcg-runtime.c (100%)
>>  rename tci.c => tcg/tci.c (100%)
>>  create mode 100644 tcg/trace-events
>>  rename translate-all.c => tcg/translate-all.c (99%)
>>  rename translate-all.h => tcg/translate-all.h (100%)
>>  rename translate-common.c => tcg/translate-common.c (100%)
>>
>