[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/1] coroutine-lock: do not touch coroutine a
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/1] coroutine-lock: do not touch coroutine after another one has been entered |
|
Date: |
Wed, 31 May 2017 15:22:58 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 31/05/2017 15:06, Stefan Hajnoczi wrote:
>> +
>> + while ((next = QSIMPLEQ_FIRST(&tmp_queue_wakeup))) {
>> + QSIMPLEQ_REMOVE_HEAD(&tmp_queue_wakeup, co_queue_next);
>> qemu_coroutine_enter(next);
>> }
>> }
> What happens if co remains alive and qemu_coroutine_enter(next) causes
> additional coroutines to add themselves to co->co_queue_wakeup?
Wouldn't that happen only if co is entered again? Then it will also
reenter qemu_co_queue_run_restart, which may cause a different wakeup
order but not any missing wakeups.
Paolo
signature.asc
Description: OpenPGP digital signature