Re: [Qemu-devel] [PATCH] msi: remove return code for msi_init()

[Paolo Bonzini]

> > >>            I'd prefer to remove msi_nonbroken completely if we don't
> > >> know where the problem is.
> > > 
> > > So you're proposing to (1) remove msi_nonbroken, (2) see which boards
> > > burst into flames, and (3) fix them, or perhaps add a less wrong stop
> > > gap msi_broken just for them?
> > 
> > Yes, adding back msi_broken is one "git revert" away.
> 
> Not sure whether I got the point here, but... Adding msi_broken is not
> a "git revert"? Since there is no msi_broken before, only
> msi_supported.

Not exactly a "git revert", but pretty close since the logic for error reporting
is the same and those are the 100 lines your patch removes.  The hard part is
finding which boards need it.

Paolo

> And iirc if we want to provide one msi_broken we need
> to know exactly all the borads that are broken with MSI, and that
> blacklist is something we don't have now (as you mentioned above)?
> 
> Please correct me if I misunderstood.
> 
> > 
> > Of course, this means the edu memory leak should be fixed in a separate
> > small patch.
> > 
> > Thanks,
> > 
> > Paolo
> 
> Thanks,
> 
> --
> Peter Xu
>