[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] coroutine-lock: do not touch coroutine afte
From: |
Roman Penyaev |
Subject: |
Re: [Qemu-devel] [PATCH 1/1] coroutine-lock: do not touch coroutine after another one has been entered |
Date: |
Tue, 30 May 2017 11:59:55 +0200 |
On Tue, May 30, 2017 at 11:35 AM, Paolo Bonzini <address@hidden> wrote:
>
>
> On 30/05/2017 10:53, Roman Pen wrote:
>> The fix is obvious: use temporal queue and do not touch coroutine after
>> first qemu_coroutine_enter() is invoked.
>>
>> The issue is quite rare and happens every ~12 hours on very high IO load
>> (building linux kernel with -j512 inside guest) when IO throttling is
>> enabled. With the fix applied guest is running ~35 hours and is still
>> alive so far.
>
> This is a good one. Thanks! Just a couple notes on English below.
I like your variant, thanks, explaining knotty things is my weak point.
Will resend v2 shortly.
--
Roman