[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 09/15] qemu-img: fix --image-opts usage with dd comma
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PULL 09/15] qemu-img: fix --image-opts usage with dd command |
Date: |
Mon, 29 May 2017 17:06:48 +0200 |
From: "Daniel P. Berrange" <address@hidden>
The --image-opts flag can only be used to affect the parsing
of the source image. The target image has to be specified in
the traditional style regardless, since it needs to be passed
to the bdrv_create() API which does not support the new style
opts.
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>
Message-id: address@hidden
Signed-off-by: Max Reitz <address@hidden>
---
qemu-img.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 181f499..4dc1d56 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -4316,8 +4316,13 @@ static int img_dd(int argc, char **argv)
goto out;
}
- blk2 = img_open(image_opts, out.filename, out_fmt, BDRV_O_RDWR,
- false, false, false);
+ /* TODO, we can't honour --image-opts for the target,
+ * since it needs to be given in a format compatible
+ * with the bdrv_create() call above which does not
+ * support image-opts style.
+ */
+ blk2 = img_open_file(out.filename, out_fmt, BDRV_O_RDWR,
+ false, false, false);
if (!blk2) {
ret = -1;
--
1.8.3.1
- [Qemu-devel] [PULL 00/15] Block layer patches, Kevin Wolf, 2017/05/29
- [Qemu-devel] [PULL 02/15] qemu-iotests: Test streaming with missing job ID, Kevin Wolf, 2017/05/29
- [Qemu-devel] [PULL 03/15] iotests: 147: Don't test inet6 if not available, Kevin Wolf, 2017/05/29
- [Qemu-devel] [PULL 01/15] stream: fix crash in stream_start() when block_job_create() fails, Kevin Wolf, 2017/05/29
- [Qemu-devel] [PULL 05/15] mirror: Drop permissions on s->target on completion, Kevin Wolf, 2017/05/29
- [Qemu-devel] [PULL 04/15] nvme: Add support for Controller Memory Buffers, Kevin Wolf, 2017/05/29
- [Qemu-devel] [PULL 08/15] qemu-img: add support for --object with 'dd' command, Kevin Wolf, 2017/05/29
- [Qemu-devel] [PULL 06/15] qcow2: remove extra local_error variable, Kevin Wolf, 2017/05/29
- [Qemu-devel] [PULL 09/15] qemu-img: fix --image-opts usage with dd command,
Kevin Wolf <=
- [Qemu-devel] [PULL 07/15] qemu-img: Fix documentation of convert, Kevin Wolf, 2017/05/29
- [Qemu-devel] [PULL 10/15] qemu-img: introduce --target-image-opts for 'convert' command, Kevin Wolf, 2017/05/29
- [Qemu-devel] [PULL 11/15] qemu-img: copy *key-secret opts when opening newly created files, Kevin Wolf, 2017/05/29
- [Qemu-devel] [PULL 13/15] block: Tweak error message related to qemu-img amend, Kevin Wolf, 2017/05/29
- [Qemu-devel] [PULL 12/15] qemu-img: Fix leakage of options on error, Kevin Wolf, 2017/05/29
- [Qemu-devel] [PULL 14/15] block: Fix backing paths for filenames with colons, Kevin Wolf, 2017/05/29
- [Qemu-devel] [PULL 15/15] block/file-*: *_parse_filename() and colons, Kevin Wolf, 2017/05/29
- Re: [Qemu-devel] [Qemu-block] [PULL 00/15] Block layer patches, Stefan Hajnoczi, 2017/05/30