Re: [Qemu-devel] [PATCH 03/26] target/s390x: implement TEST AND SET

qemu-devel

From:	Richard Henderson
Subject:	Re: [Qemu-devel] [PATCH 03/26] target/s390x: implement TEST AND SET
Date:	Fri, 26 May 2017 06:42:08 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0

On 05/25/2017 02:04 PM, Aurelien Jarno wrote:

+    TCGv_i32 t1 = tcg_const_i32(0xff);
+    tcg_gen_atomic_fetch_or_i32(t1, o->in2, t1, get_mem_index(s), MO_UB);


Better as tcg_gen_atomic_xchg_i32.


r~

Current Thread

[Next in Thread]

[Qemu-devel] [PATCH 00/26] target/s390x: fix, improve and implement some more instructions, Aurelien Jarno, 2017/05/25
- [Qemu-devel] [PATCH 03/26] target/s390x: implement TEST AND SET, Aurelien Jarno, 2017/05/25
  - Re: [Qemu-devel] [PATCH 03/26] target/s390x: implement TEST AND SET, Richard Henderson <=
- [Qemu-devel] [PATCH 05/26] target/s390x: implement PACK, Aurelien Jarno, 2017/05/25
  - Re: [Qemu-devel] [PATCH 05/26] target/s390x: implement PACK, Richard Henderson, 2017/05/26
- [Qemu-devel] [PATCH 01/26] target/s390x: remove dead code in translate.c, Aurelien Jarno, 2017/05/25
  - Re: [Qemu-devel] [PATCH 01/26] target/s390x: remove dead code in translate.c, Richard Henderson, 2017/05/26
- [Qemu-devel] [PATCH 08/26] target/s390x: implement MOVE INVERSE, Aurelien Jarno, 2017/05/25
  - Re: [Qemu-devel] [PATCH 08/26] target/s390x: implement MOVE INVERSE, Richard Henderson, 2017/05/26
- [Qemu-devel] [PATCH 09/26] target/s390x: implement MOVE NUMERICS, Aurelien Jarno, 2017/05/25
  - Re: [Qemu-devel] [PATCH 09/26] target/s390x: implement MOVE NUMERICS, Richard Henderson, 2017/05/26
- [Qemu-devel] [PATCH 14/26] target/s390x: improve 24-bit and 31-bit lengths read/write, Aurelien Jarno, 2017/05/25
  - Re: [Qemu-devel] [PATCH 14/26] target/s390x: improve 24-bit and 31-bit lengths read/write, Richard Henderson, 2017/05/26