[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new T
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock |
Date: |
Tue, 23 May 2017 22:01:31 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 23.05.2017 17:54, Richard Henderson wrote:
> On 05/23/2017 03:48 AM, Aurelien Jarno wrote:
>> On 2017-05-22 20:02, Richard Henderson wrote:
>>> Previously, helper_ex would construct the insn and then implement
>>> the insn via direct calls other helpers. This was sufficient to
>>> boot Linux but that is all.
>>>
>>> It is easy enough to go the whole nine yards by stashing state for
>>> EXECUTE within the cpu, and then relying on a new TB to be created
>>> that properly and completely interprets the insn.
>>>
>>> Signed-off-by: Richard Henderson <address@hidden>
>>> ---
>>> target/s390x/cpu.h | 4 +-
>>> target/s390x/helper.h | 2 +-
>>> target/s390x/insn-data.def | 4 +-
>>> target/s390x/machine.c | 19 +++++++
>>> target/s390x/mem_helper.c | 136
>>> +++++++++++----------------------------------
>>> target/s390x/translate.c | 124
>>> +++++++++++++++++++++++++----------------
>>> 6 files changed, 133 insertions(+), 156 deletions(-)
>>
>> This looks good on the principle, and finally removes a big hack. That
>> said it prevent my test system to boot. I haven't investigated why yet.
>
> Hmm. I've not got a complete environment -- merely booting a kernel up
> to the point it fails to find a rootfs. Which did find several problems
> with my first attempts at this, but wouldn't have exercised paging.
> I'll try again to get a full install working...
Something nice for a quick test is also:
http://www.qemu-advent-calendar.org/2014/download/s390-moon-buggy.tar.xz
Not sure whether it will trigger your EXECUTE problem, though.
Thomas
- [Qemu-devel] [PATCH 03/31] target/s390x: Use unwind data for helper_nc, (continued)
- [Qemu-devel] [PATCH 03/31] target/s390x: Use unwind data for helper_nc, Richard Henderson, 2017/05/22
- [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock, Richard Henderson, 2017/05/22
- Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock, Aurelien Jarno, 2017/05/23
- Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock, Richard Henderson, 2017/05/23
- Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock, Aurelien Jarno, 2017/05/23
- Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock, Richard Henderson, 2017/05/23
- Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock, Aurelien Jarno, 2017/05/24
- Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock, Richard Henderson, 2017/05/24
- Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock,
Thomas Huth <=
- Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock, Aurelien Jarno, 2017/05/23
[Qemu-devel] [PATCH 04/31] target/s390x: Use unwind data for helper_xc, Richard Henderson, 2017/05/22
[Qemu-devel] [PATCH 05/31] target/s390x: Use unwind data for helper_oc, Richard Henderson, 2017/05/22
[Qemu-devel] [PATCH 06/31] target/s390x: Use unwind data for helper_mvc, Richard Henderson, 2017/05/22