[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] Improve Cocoa modifier key handling
|
From: |
Ian McKellar |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/1] Improve Cocoa modifier key handling |
|
Date: |
Tue, 23 May 2017 15:52:52 +0000 |
On Tue, May 23, 2017 at 3:03 AM Gerd Hoffmann <address@hidden> wrote:
> Sounds like this happens in case there is a modifier state change
> without linked key event, such as state change while qemu did not have
> the keyboard focus. Nice that macos sends notifications in that case.
>
Yeah, I guess it makes sense to send an event to update modifier state when
keyboard focus returns.
>
> I'm wondering whenever we should just use modifierFlags all the time.
>
Probably. My initial patch tried to be minimally intrusive but I can try
reworking the NSEventTypeFlagsChanged handling to compare the new
modifierFlags to the last we've seen and synthesize the appropriate key
down/up events.
Ian