[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 0/5] Remove old MigrationParams
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH v5 0/5] Remove old MigrationParams |
Date: |
Wed, 17 May 2017 17:38:07 +0200 |
Hi
changes from v4:
- Address Markus review
* better documentation messages (thanks)
* reorganize error checking to have small data
* Use g_new0
* Improve commints messages
Please review.
[v4]
- patch 1 included again. We have a 'block' capability and a
'block_incremental' parameter
Make Dave happy: rename shared into incremental
Make Eric and Markus happy:
block: off -> no block migration, we don't care about
block_incremental value
block: on block_incremental: off -> no incremental block migration
block: on block_incremental: on -> incremental block migration
- Use visitors.
You ask if there is not a better way than hand coding a boolean parser.
QAPI people (a.k.a. Markus) answer to use a visitor.
Once there, I used it also for integers, not only booleans.
- Use -b/-i parameters. OK, I bit the bullet: You can't use
capabilities/parameters and -b/-i: it gives you one error If you use
-b/-i, capability parameter is cleanup after the migration ends (Who
would have guessed that there are cases where we call
migration_fd_error(), but not migration_fd_cleanup()
I think this should make Peter and Markus and Dave happy.
- Integrate migrate block compile time disabling
Well, it conflicted left and right, so I fixed it
Once there, I disable setting/getting block capability if it is disabled.
[v3]
- Patch 1 included in pull request
- disable block_shared when we disable block_enable
- enable block_enabled when we enable block_shared
[v2]
- make migrate_block_set_* take a boolean
- disable block migration in colo to maintain semantics.
[v1]
Upon a time there were MigrationParms (only used for block migration)
and then MigrationParams used for everything else. This series:
- create migration capabilities for block parameters
- make the migrate command line parameters to use capabilities
- remove MigrationParams completely
Dr. David Alan Gilbert (1):
block migration: Allow compile time disable
Juan Quintela (4):
hmp: Use visitor api for hmp_migrate_set_parameter()
migration: Create block capability
migration: Remove use of old MigrationParams
migration: Remove old MigrationParams
configure | 11 +++++
hmp.c | 23 ++++++++--
include/migration/block.h | 24 +++++++++++
include/migration/migration.h | 17 ++++----
include/migration/vmstate.h | 1 -
include/qemu/typedefs.h | 1 -
include/sysemu/sysemu.h | 3 +-
migration/Makefile.objs | 2 +-
migration/block.c | 17 +-------
migration/colo.c | 6 +--
migration/migration.c | 97 +++++++++++++++++++++++++++++++++++++++----
migration/savevm.c | 24 ++++-------
qapi-schema.json | 28 +++++++++++--
13 files changed, 192 insertions(+), 62 deletions(-)
--
2.9.3
- [Qemu-devel] [PATCH v5 0/5] Remove old MigrationParams,
Juan Quintela <=