[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 4/6] cputlb: remove tlb_flush_count
From: |
Alex Bennée |
Subject: |
[Qemu-devel] [PATCH v2 4/6] cputlb: remove tlb_flush_count |
Date: |
Wed, 17 May 2017 15:52:57 +0100 |
Flushing of the CPU TLB is no longer a simple count. The ratio of
self-flushes to cross-flushes and if they need to synchronise across
vCPUs has more of an impact. To correctly capture this we'll replace
the simple count with trace points in a future patch.
Signed-off-by: Alex Bennée <address@hidden>
---
cputlb.c | 4 ----
include/exec/cputlb.h | 1 -
translate-all.c | 1 -
3 files changed, 6 deletions(-)
diff --git a/cputlb.c b/cputlb.c
index f5d056cc08..d1859c3f37 100644
--- a/cputlb.c
+++ b/cputlb.c
@@ -92,9 +92,6 @@ static void flush_all_helper(CPUState *src, run_on_cpu_func
fn,
}
}
-/* statistics */
-int tlb_flush_count;
-
/* This is OK because CPU architectures generally permit an
* implementation to drop entries from the TLB at any time, so
* flushing more entries than required is only an efficiency issue,
@@ -112,7 +109,6 @@ static void tlb_flush_nocheck(CPUState *cpu)
}
assert_cpu_is_self(cpu);
- tlb_debug("(count: %d)\n", tlb_flush_count++);
tb_lock();
diff --git a/include/exec/cputlb.h b/include/exec/cputlb.h
index 3f941783c5..dac9901da5 100644
--- a/include/exec/cputlb.h
+++ b/include/exec/cputlb.h
@@ -23,7 +23,6 @@
/* cputlb.c */
void tlb_protect_code(ram_addr_t ram_addr);
void tlb_unprotect_code(ram_addr_t ram_addr);
-extern int tlb_flush_count;
#endif
#endif
diff --git a/translate-all.c b/translate-all.c
index b3ee876526..eeb3807242 100644
--- a/translate-all.c
+++ b/translate-all.c
@@ -1927,7 +1927,6 @@ void dump_exec_info(FILE *f, fprintf_function cpu_fprintf)
atomic_read(&tcg_ctx.tb_ctx.tb_flush_count));
cpu_fprintf(f, "TB invalidate count %d\n",
tcg_ctx.tb_ctx.tb_phys_invalidate_count);
- cpu_fprintf(f, "TLB flush count %d\n", tlb_flush_count);
tcg_dump_info(f, cpu_fprintf);
tb_unlock();
--
2.11.0
- [Qemu-devel] [PATCH v2 0/6] gdb updates and cputlb traces, Alex Bennée, 2017/05/17
- [Qemu-devel] [PATCH v2 2/6] scripts/qemu-gdb/timers.py: new helper to dump timer state, Alex Bennée, 2017/05/17
- [Qemu-devel] [PATCH v2 3/6] scripts/qemu-gdb/tcg: new helper to dump tcg state, Alex Bennée, 2017/05/17
- [Qemu-devel] [PATCH v2 4/6] cputlb: remove tlb_flush_count,
Alex Bennée <=
- [Qemu-devel] [PATCH v2 1/6] scripts/replay-dump.py: replay log dumper, Alex Bennée, 2017/05/17
- [Qemu-devel] [PATCH v2 5/6] cputlb: add trace events, Alex Bennée, 2017/05/17
- [Qemu-devel] [PATCH v2 6/6] new script/analyse-tlb-flushes-simpletrace.py, Alex Bennée, 2017/05/17
- Re: [Qemu-devel] [PATCH v2 0/6] gdb updates and cputlb traces, Stefan Hajnoczi, 2017/05/18