Re: [Qemu-devel] [PATCH v8 0/5] event: Add source information to SHUTDOWN

[Eric Blake]

On 05/15/2017 03:37 PM, address@hidden wrote:
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 

> Checking PATCH 5/5: shutdown: Expose bool cause in SHUTDOWN and RESET 
> events...
> ERROR: open brace '{' following function declarations go on the next line
> #61: FILE: include/sysemu/sysemu.h:52:
> +static inline bool shutdown_caused_by_guest(ShutdownCause cause) {
> 

Oh fine (I have a hook to run checkpatch locally on every commit; wonder
why it didn't gripe at me). I also missed a FIXME that should have been
TODO in 2/5.   v9 coming up.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature