[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: Move check_migratable() into qdev.c
|
From: |
Juan Quintela |
|
Subject: |
Re: [Qemu-devel] [PATCH] migration: Move check_migratable() into qdev.c |
|
Date: |
Thu, 11 May 2017 16:46:28 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Juan Quintela <address@hidden> wrote:
> The function is only used once, and nothing else in migration knows
> about objects. Create the function vmstate_device_is_migratable() in
> savem.c that really do the bit that is related with migration.
>
> Signed-off-by: Juan Quintela <address@hidden>
Hi, I forget to "add" the comments section.
I switched to Peter Xu idea of only testing ->unmigratable is savevm.c
and move the only_migratable check to qdev.c.
Once there, change the return types from -1/0 to true/false and improve
slightly the naming.
Please, comment.