[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 17/18] block: introduce block_account_one_io
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 17/18] block: introduce block_account_one_io |
Date: |
Thu, 11 May 2017 16:42:07 +0200 |
This is the common code to account operations that produced actual I/O.
Signed-off-by: Paolo Bonzini <address@hidden>
---
v1->v2: new, to hoist qemu_clock_get_ns out of the
"if (!stats->account_failed)" case. Failed operations
are not a fast path, so getting the current time
unconditionally is not an issue. [Stefan]
block/accounting.c | 50 +++++++++++++++++++++-----------------------------
1 file changed, 21 insertions(+), 29 deletions(-)
diff --git a/block/accounting.c b/block/accounting.c
index 3f457c4e73..0429e31c9f 100644
--- a/block/accounting.c
+++ b/block/accounting.c
@@ -86,7 +86,7 @@ void block_acct_start(BlockAcctStats *stats, BlockAcctCookie
*cookie,
cookie->type = type;
}
-void block_acct_done(BlockAcctStats *stats, BlockAcctCookie *cookie)
+static void block_account_one_io(BlockAcctStats *stats, BlockAcctCookie
*cookie, bool failed)
{
BlockAcctTimedStats *s;
int64_t time_ns = qemu_clock_get_ns(clock_type);
@@ -98,31 +98,14 @@ void block_acct_done(BlockAcctStats *stats, BlockAcctCookie
*cookie)
assert(cookie->type < BLOCK_MAX_IOTYPE);
- stats->nr_bytes[cookie->type] += cookie->bytes;
- stats->nr_ops[cookie->type]++;
- stats->total_time_ns[cookie->type] += latency_ns;
- stats->last_access_time_ns = time_ns;
-
- QSLIST_FOREACH(s, &stats->intervals, entries) {
- timed_average_account(&s->latency[cookie->type], latency_ns);
+ if (failed) {
+ stats->failed_ops[cookie->type]++;
+ } else {
+ stats->nr_bytes[cookie->type] += cookie->bytes;
+ stats->nr_ops[cookie->type]++;
}
-}
-
-void block_acct_failed(BlockAcctStats *stats, BlockAcctCookie *cookie)
-{
- assert(cookie->type < BLOCK_MAX_IOTYPE);
-
- stats->failed_ops[cookie->type]++;
-
- if (stats->account_failed) {
- BlockAcctTimedStats *s;
- int64_t time_ns = qemu_clock_get_ns(clock_type);
- int64_t latency_ns = time_ns - cookie->start_time_ns;
-
- if (qtest_enabled()) {
- latency_ns = qtest_latency_ns;
- }
+ if (!failed || stats->account_failed) {
stats->total_time_ns[cookie->type] += latency_ns;
stats->last_access_time_ns = time_ns;
@@ -132,15 +115,24 @@ void block_acct_failed(BlockAcctStats *stats,
BlockAcctCookie *cookie)
}
}
+void block_acct_done(BlockAcctStats *stats, BlockAcctCookie *cookie)
+{
+ block_account_one_io(stats, cookie, false);
+}
+
+void block_acct_failed(BlockAcctStats *stats, BlockAcctCookie *cookie)
+{
+ block_account_one_io(stats, cookie, true);
+}
+
void block_acct_invalid(BlockAcctStats *stats, enum BlockAcctType type)
{
assert(type < BLOCK_MAX_IOTYPE);
- /* block_acct_done() and block_acct_failed() update
- * total_time_ns[], but this one does not. The reason is that
- * invalid requests are accounted during their submission,
- * therefore there's no actual I/O involved. */
-
+ /* block_account_one_io() updates total_time_ns[], but this one does
+ * not. The reason is that invalid requests are accounted during their
+ * submission, therefore there's no actual I/O involved.
+ */
stats->invalid_ops[type]++;
if (stats->account_invalid) {
--
2.12.2
- Re: [Qemu-devel] [PATCH 13/18] block: protect tracked_requests and flush_queue with reqs_lock, (continued)
- [Qemu-devel] [PATCH 11/18] block: use Stat64 for wr_highest_offset, Paolo Bonzini, 2017/05/11
- [Qemu-devel] [PATCH 12/18] block: access write_gen with atomics, Paolo Bonzini, 2017/05/11
- [Qemu-devel] [PATCH 15/18] migration/block: reset dirty bitmap before reading, Paolo Bonzini, 2017/05/11
- [Qemu-devel] [PATCH 14/18] block: introduce dirty_bitmap_mutex, Paolo Bonzini, 2017/05/11
- [Qemu-devel] [PATCH 18/18] block: make accounting thread-safe, Paolo Bonzini, 2017/05/11
- [Qemu-devel] [PATCH 17/18] block: introduce block_account_one_io,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 16/18] block: protect modification of dirty bitmaps with a mutex, Paolo Bonzini, 2017/05/11
- Re: [Qemu-devel] [PATCH v2 00/18] Block layer thread safety, part 1, no-reply, 2017/05/11
- Re: [Qemu-devel] [PATCH v2 00/18] Block layer thread safety, part 1, no-reply, 2017/05/11
- Re: [Qemu-devel] [PATCH v2 00/18] Block layer thread safety, part 1, Stefan Hajnoczi, 2017/05/16
- Re: [Qemu-devel] [PATCH v2 00/18] Block layer thread safety, part 1, Paolo Bonzini, 2017/05/24