Re: [Qemu-devel] [RFC PATCH v1 0/9] BQL and Replay Lock changes

[Pavel Dovgalyuk]

> From: Alex Bennée [mailto:address@hidden
> Pavel Dovgalyuk <address@hidden> writes:
> 
> > Guest Windows XP doesn't boot with these patches.
> 
> I'm guessing there is hardware attached to that machine? 

Only mouse, keyboard and hdd.

> Did the asserts catch double locking? 

No, they didn't.
The emulation also became much slower.
Maybe Windows boots, but with huge slowdown?

> As I said there are still changes to be made to
> the hardware emulation that saves async events with the device data.

What devices do you mean?

> But the real question is do you think that re-purposing replay_lock to
> give the sequential guarantees that the BQL used to is the right
> approach?

This approach seems to be ok - you raised the lock and io/cpu threads are now 
synchronized.
This is how BQL worked before.


Pavel Dovgalyuk