[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/4] throttle: factor out duplicate code
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 1/4] throttle: factor out duplicate code |
|
Date: |
Wed, 10 May 2017 14:48:05 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/10/2017 10:27 AM, Pradeep Jagadeesh wrote:
>>
>> Isn't it a bit overkill to introduce a new file for a single function ?
>> Maybe you could simply move this to util/throttle.c ?
>>
> OK, but I will add one more function later patch. Still do you think
> better to move to util/thottle.c?
As long as util/throttle.c is not already huge, adding multiple new
functions to that file over the course of the series should be just fine.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v4 2/4] qmp: Create IOThrottle structure, Pradeep Jagadeesh, 2017/05/10
[Qemu-devel] [PATCH v4 3/4] qmp: refactor duplicate code, Pradeep Jagadeesh, 2017/05/10
[Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling, Pradeep Jagadeesh, 2017/05/10