|
From: | Manos Pitsidianakis |
Subject: | Re: [Qemu-devel] [Qemu-block] [PATCH] block: curl: Allow passing cookies via QCryptoSecret |
Date: | Tue, 9 May 2017 22:43:44 +0300 |
User-agent: | NeoMutt/20170306-97-7656f1-dirty (1.8.0) |
On Thu, May 04, 2017 at 04:00:06PM +0200, Peter Krempa wrote:
+ cookie_secret = qemu_opt_get(opts, CURL_BLOCK_OPT_COOKIE_SECRET); + + if (cookie && cookie_secret) { + error_setg(errp, + "curl driver cannot handle both cookie and cookie secret"); + goto out_noclean; + } + + if (cookie_secret) { + s->cookie = qcrypto_secret_lookup_as_utf8(cookie_secret, errp); + if (!s->cookie) { + goto out_noclean; + } + } else { + s->cookie = g_strdup(cookie); + }
There's no check here for if both cookie and cookie_secret are NULL.
[Prev in Thread] | Current Thread | [Next in Thread] |