[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v3 24/28] qmp-shell: add persistent command history
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL v3 24/28] qmp-shell: add persistent command history |
Date: |
Tue, 9 May 2017 10:06:41 +0200 |
From: John Snow <address@hidden>
Use the existing readline history function we are utilizing
to provide persistent command history across instances of qmp-shell.
This assists entering debug commands across sessions that may be
interrupted by QEMU sessions terminating, where the qmp-shell has
to be relaunched.
Signed-off-by: John Snow <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Kashyap Chamarthy <address@hidden>
Tested-by: Kashyap Chamarthy <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
scripts/qmp/qmp-shell | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell
index eccb88a..6ece6e7 100755
--- a/scripts/qmp/qmp-shell
+++ b/scripts/qmp/qmp-shell
@@ -70,6 +70,9 @@ import json
import ast
import readline
import sys
+import os
+import errno
+import atexit
class QMPCompleter(list):
def complete(self, text, state):
@@ -109,6 +112,8 @@ class QMPShell(qmp.QEMUMonitorProtocol):
self._pretty = pretty
self._transmode = False
self._actions = list()
+ self._histfile = os.path.join(os.path.expanduser('~'),
+ '.qmp-shell_history')
def __get_address(self, arg):
"""
@@ -132,11 +137,27 @@ class QMPShell(qmp.QEMUMonitorProtocol):
def __completer_setup(self):
self._completer = QMPCompleter()
self._fill_completion()
+ readline.set_history_length(1024)
readline.set_completer(self._completer.complete)
readline.parse_and_bind("tab: complete")
# XXX: default delimiters conflict with some command names (eg.
query-),
# clearing everything as it doesn't seem to matter
readline.set_completer_delims('')
+ try:
+ readline.read_history_file(self._histfile)
+ except Exception as e:
+ if isinstance(e, IOError) and e.errno == errno.ENOENT:
+ # File not found. No problem.
+ pass
+ else:
+ print "Failed to read history '%s'; %s" % (self._histfile, e)
+ atexit.register(self.__save_history)
+
+ def __save_history(self):
+ try:
+ readline.write_history_file(self._histfile)
+ except Exception as e:
+ print "Failed to save history file '%s'; %s" % (self._histfile, e)
def __parse_value(self, val):
try:
--
2.7.4
- [Qemu-devel] [PULL v3 00/28] QAPI patches for 2017-05-04, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 10/28] QemuOpts: Simplify qemu_opts_to_qdict(), Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 09/28] block: Simplify bdrv_append_temp_snapshot() logic, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 07/28] qobject: Add helper macros for common scalar insertions, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 25/28] qmp-shell: add -N option to skip negotiate, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 24/28] qmp-shell: add persistent command history,
Markus Armbruster <=
- [Qemu-devel] [PULL v3 04/28] pci: Reduce scope of error injection, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 05/28] coccinelle: Add script to remove useless QObject casts, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 11/28] fdc-test: Avoid deprecated 'change' command, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 15/28] qapi: New QAPI_CLONE_MEMBERS(), Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 27/28] qmp-shell: don't show version greeting if unavailable, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 01/28] tests/check-qdict: Fix missing brackets, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 19/28] sockets: Delete unused helper socket_address_crumple(), Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 22/28] qapi: Document intended use of @name within alternate visits, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 06/28] qobject: Drop useless QObject casts, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 17/28] sockets: Rename SocketAddressFlat to SocketAddress, Markus Armbruster, 2017/05/09