[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 05/21] docker: compact debian base
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v2 05/21] docker: compact debian base |
Date: |
Tue, 9 May 2017 12:04:38 +0800 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Mon, 05/08 19:17, Philippe Mathieu-Daudé wrote:
> - install common/basic tools at once
> - use eatmydata and remove apt cache to save space
> - add bison and flex and git
> - create deb-src entry and setup Emdebian in the same layer
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/docker/dockerfiles/debian.docker | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/tests/docker/dockerfiles/debian.docker
> b/tests/docker/dockerfiles/debian.docker
> index d08def6a8d..dcded3ce84 100644
> --- a/tests/docker/dockerfiles/debian.docker
> +++ b/tests/docker/dockerfiles/debian.docker
> @@ -9,17 +9,17 @@
> #
> FROM debian:stable-slim
>
> -# Setup some basic tools we need
> -RUN apt update
> -RUN apt install -yy aptitude ca-certificates curl
> +# Install some basic tools and common build utilities
> +RUN apt-get update && \
> + DEBIAN_FRONTEND=noninteractive apt-get install -yy \
> + eatmydata && \
> + DEBIAN_FRONTEND=noninteractive eatmydata apt-get install -y
> --no-install-recommends \
> + aptitude ca-certificates curl \
> + build-essential clang git \
> + bison flex && \
> + apt-get clean
Any particular reason to make multiple "RUN" directives into one?
Fam
>
> -# Setup Emdebian
> -RUN echo "deb http://emdebian.org/tools/debian/ jessie main" >>
> /etc/apt/sources.list
> -RUN curl http://emdebian.org/tools/debian/emdebian-toolchain-archive.key |
> apt-key add -
> -
> -# Duplicate deb line as deb-src
> -RUN cat /etc/apt/sources.list | sed "s/deb/deb-src/" >> /etc/apt/sources.list
> -
> -# Install common build utilities
> -RUN apt update
> -RUN apt install -yy build-essential clang
> +# Duplicate deb line as deb-src, setup Emdebian
> +RUN cat /etc/apt/sources.list | sed "s/deb/deb-src/" >>
> /etc/apt/sources.list && \
> + echo "deb http://emdebian.org/tools/debian/ jessie main" >>
> /etc/apt/sources.list && \
> + curl http://emdebian.org/tools/debian/emdebian-toolchain-archive.key |
> apt-key add -
> --
> 2.11.0
>
- [Qemu-devel] [PATCH v2 00/21] docker/shippable: cross-build mipsel and powerpc targets, Philippe Mathieu-Daudé, 2017/05/08
- [Qemu-devel] [PATCH v2 02/21] docker: add --include-file argument to 'build' command, Philippe Mathieu-Daudé, 2017/05/08
- [Qemu-devel] [PATCH v2 01/21] docker: let _copy_with_mkdir() sub_path argument be optional, Philippe Mathieu-Daudé, 2017/05/08
- [Qemu-devel] [PATCH v2 03/21] docker: add 'apt-fake' script which generate fake debian packages, Philippe Mathieu-Daudé, 2017/05/08
- [Qemu-devel] [PATCH v2 04/21] docker: install ca-certificates package in base image, Philippe Mathieu-Daudé, 2017/05/08
- [Qemu-devel] [PATCH v2 05/21] docker: compact debian base, Philippe Mathieu-Daudé, 2017/05/08
- Re: [Qemu-devel] [PATCH v2 05/21] docker: compact debian base,
Fam Zheng <=
[Qemu-devel] [PATCH v2 06/21] docker: compact debian armhf, Philippe Mathieu-Daudé, 2017/05/08
[Qemu-devel] [PATCH v2 07/21] docker: compact debian arm64, Philippe Mathieu-Daudé, 2017/05/08
[Qemu-devel] [PATCH v2 08/21] docker: add extra libs to armhf target to extend codebase coverage, Philippe Mathieu-Daudé, 2017/05/08
[Qemu-devel] [PATCH v2 09/21] docker: add extra libs to arm64 target to extend codebase coverage, Philippe Mathieu-Daudé, 2017/05/08
[Qemu-devel] [PATCH v2 10/21] docker: add extra libs to s390x target to extend codebase coverage, Philippe Mathieu-Daudé, 2017/05/08
[Qemu-devel] [PATCH v2 11/21] docker: add mipsel build target, Philippe Mathieu-Daudé, 2017/05/08