[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] slirp: don't zero ti_i since we acccess it
|
From: |
Samuel Thibault |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/1] slirp: don't zero ti_i since we acccess it later. |
|
Date: |
Mon, 8 May 2017 21:54:04 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
Hello,
lepton, on lun. 08 mai 2017 12:08:55 -0700, wrote:
> 1. For some reason, caller didn't setup anything in tcpiphdr, so there is
> random data inside it.
> 2. For some reason, caller setup correct src/dst address in tcpiphdr but
> don't
> zero ix_h1
> If you still think this doesn't look likely happen,
Well, 1) is very likely to have been spotten another way. And crashing
just because of 2) is harsh on users.
The original code was setting ih_x1 at this point, so that was the
original intent.
> I am fine with your suggestion and will add zero for ih_x1, any
> comments?
Samuel