[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v13 06/12] qcow2: Make distinction between zero
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v13 06/12] qcow2: Make distinction between zero cluster types obvious |
|
Date: |
Mon, 8 May 2017 12:15:53 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/08/2017 10:54 AM, Max Reitz wrote:
> On 07.05.2017 02:05, Eric Blake wrote:
>> Treat plain zero clusters differently from allocated ones, so that
>> we can simplify the logic of checking whether an offset is present.
>> Do this by splitting QCOW2_CLUSTER_ZERO into two new enums,
>> QCOW2_CLUSTER_ZERO_PLAIN and QCOW2_CLUSTER_ZERO_ALLOC.
>>
> (No, I'm not mentioning the fact that 060.out contains one more mention
> of "Data cluster offset" that should definitely be a "Cluster allocation
> offset" or even "Preallocated zero cluster offset" at
> block/qcow2-cluster.c:1780, because let's really worry about this later)
Oh, you mean this?
https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg01784.html
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v13 04/12] qcow2: Correctly report status of preallocated zero clusters, (continued)
- [Qemu-devel] [PATCH v13 04/12] qcow2: Correctly report status of preallocated zero clusters, Eric Blake, 2017/05/06
- [Qemu-devel] [PATCH v13 05/12] qcow2: Name typedef for cluster type, Eric Blake, 2017/05/06
- [Qemu-devel] [PATCH v13 07/12] qcow2: Optimize zero_single_l2() to minimize L2 churn, Eric Blake, 2017/05/06
- [Qemu-devel] [PATCH v13 11/12] qcow2: Assert that cluster operations are aligned, Eric Blake, 2017/05/06
- [Qemu-devel] [PATCH v13 08/12] iotests: Improve _filter_qemu_img_map, Eric Blake, 2017/05/06
- [Qemu-devel] [PATCH v13 06/12] qcow2: Make distinction between zero cluster types obvious, Eric Blake, 2017/05/06
- [Qemu-devel] [PATCH v13 12/12] qcow2: Discard/zero clusters by byte count, Eric Blake, 2017/05/06
- [Qemu-devel] [PATCH v13 09/12] iotests: Add test 179 to cover write zeroes with unmap, Eric Blake, 2017/05/06
- [Qemu-devel] [PATCH v13 10/12] qcow2: Optimize write zero of unaligned tail cluster, Eric Blake, 2017/05/06
- Re: [Qemu-devel] [PATCH v13 00/12] qcow2 zero-cluster tweaks [was add blkdebug tests], Max Reitz, 2017/05/08