[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH v1 4/9] replay/replay-internal.c: track holding
From: |
Alex Bennée |
Subject: |
[Qemu-devel] [RFC PATCH v1 4/9] replay/replay-internal.c: track holding of replay_lock |
Date: |
Fri, 5 May 2017 11:38:17 +0100 |
This is modelled after the iothread mutex lock. We keep a TLS flag to
indicate when that thread has acquired the lock and assert we don't
double-lock or release when we shouldn't have.
Signed-off-by: Alex Bennée <address@hidden>
---
replay/replay-internal.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/replay/replay-internal.c b/replay/replay-internal.c
index fca8514012..157c863e25 100644
--- a/replay/replay-internal.c
+++ b/replay/replay-internal.c
@@ -179,13 +179,24 @@ void replay_mutex_destroy(void)
qemu_mutex_destroy(&lock);
}
+static __thread bool replay_locked;
+
+static bool replay_mutex_locked(void)
+{
+ return replay_locked;
+}
+
void replay_mutex_lock(void)
{
+ g_assert(!replay_mutex_locked());
qemu_mutex_lock(&lock);
+ replay_locked = true;
}
void replay_mutex_unlock(void)
{
+ g_assert(replay_mutex_locked());
+ replay_locked = false;
qemu_mutex_unlock(&lock);
}
--
2.11.0
- [Qemu-devel] [RFC PATCH v1 0/9] BQL and Replay Lock changes, Alex Bennée, 2017/05/05
- [Qemu-devel] [RFC PATCH v1 1/9] target/arm/arm-powertctl: drop BQL assertions, Alex Bennée, 2017/05/05
- [Qemu-devel] [RFC PATCH v1 5/9] replay: make locking visible outside replay code, Alex Bennée, 2017/05/05
- [Qemu-devel] [RFC PATCH v1 2/9] cpus: push BQL lock to qemu_*_wait_io_event, Alex Bennée, 2017/05/05
- [Qemu-devel] [RFC PATCH v1 3/9] cpus: only take BQL for sleeping threads, Alex Bennée, 2017/05/05
- [Qemu-devel] [RFC PATCH v1 4/9] replay/replay-internal.c: track holding of replay_lock,
Alex Bennée <=
- [Qemu-devel] [RFC PATCH v1 8/9] util/qemu-thread-*: add qemu_lock, locked and unlock trace events, Alex Bennée, 2017/05/05
- Re: [Qemu-devel] [RFC PATCH v1 8/9] util/qemu-thread-*: add qemu_lock, locked and unlock trace events, Paolo Bonzini, 2017/05/05
- Re: [Qemu-devel] [RFC PATCH v1 8/9] util/qemu-thread-*: add qemu_lock, locked and unlock trace events, Alex Bennée, 2017/05/05
- Re: [Qemu-devel] [RFC PATCH v1 8/9] util/qemu-thread-*: add qemu_lock, locked and unlock trace events, Paolo Bonzini, 2017/05/06
- Re: [Qemu-devel] [RFC PATCH v1 8/9] util/qemu-thread-*: add qemu_lock, locked and unlock trace events, Stefan Hajnoczi, 2017/05/08
- Re: [Qemu-devel] [RFC PATCH v1 8/9] util/qemu-thread-*: add qemu_lock, locked and unlock trace events, Alex Bennée, 2017/05/09
- Re: [Qemu-devel] [RFC PATCH v1 8/9] util/qemu-thread-*: add qemu_lock, locked and unlock trace events, Paolo Bonzini, 2017/05/09
[Qemu-devel] [RFC PATCH v1 6/9] replay: push replay_mutex_lock up the call tree, Alex Bennée, 2017/05/05
[Qemu-devel] [RFC PATCH v1 7/9] scripts/qemu-gdb: add simple tcg lock status helper, Alex Bennée, 2017/05/05
[Qemu-devel] [RFC PATCH v1 9/9] scripts/analyse-locks-simpletrace.py: script to analyse lock times, Alex Bennée, 2017/05/05