[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] QEMU build breakage on ARM against Xen 4.9 caused by li
|
From: |
Wei Liu |
|
Subject: |
Re: [Qemu-devel] QEMU build breakage on ARM against Xen 4.9 caused by libxendevicemodel |
|
Date: |
Thu, 4 May 2017 12:08:24 +0100 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Wed, May 03, 2017 at 05:55:36PM +0100, Anthony PERARD wrote:
> > > --- a/tools/libs/devicemodel/Makefile
> > > +++ b/tools/libs/devicemodel/Makefile
> > > @@ -63,7 +63,7 @@ libxendevicemodel.so.$(MAJOR):
> > > libxendevicemodel.so.$(MAJOR).$(MINOR)
> > > $(SYMLINK_SHLIB) $< $@
> > >
> > > libxendevicemodel.so.$(MAJOR).$(MINOR): $(PIC_OBJS) libxendevicemodel.map
> > > - $(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG)
> > > -Wl,libxendevicemodel.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS)
> > > $(LDLIBS_libxentoollog) $(APPEND_LDFLAGS)
> > > + $(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG)
> > > -Wl,libxendevicemodel.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS)
> > > $(LDLIBS_libxentoollog) $(LDLIBS_libxencall) $(APPEND_LDFLAGS)
> > >
> >
> > Isn't the dependency already encoded in tools/Rules.mk?
>
> How? Which makefile variable would include -lxencall in the abrove line?
>
I was thinking about SHDEPS_* in Rules.mk. That's for something else.
And you're right. We should fix it here.
Wei.