[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 1/4] curl: do not use aio_context_acquire/release
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL 1/4] curl: do not use aio_context_acquire/release |
Date: |
Wed, 3 May 2017 18:08:57 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 03/05/2017 17:55, Richard W.M. Jones wrote:
> On Wed, May 03, 2017 at 05:46:49PM +0200, Paolo Bonzini wrote:
>> Please test this:
>>
>> diff --git a/block/curl.c b/block/curl.c
>> index 2708d57c2f..cfe02bfd79 100644
>> --- a/block/curl.c
>> +++ b/block/curl.c
>> @@ -467,7 +467,9 @@ static CURLState *curl_init_state(BlockDriverState
>> *bs, BDRVCURLState *s)
>> break;
>> }
>> if (!state) {
>> + qemu_mutex_unlock(&s->mutex);
>> aio_poll(bdrv_get_aio_context(bs), true);
>> + qemu_mutex_lock(&s->mutex);
>> }
>> } while(!state);
>>
>>
>
> Yes, this fixes it, thanks Paolo.
>
> Reported-by: Kun Wei <address@hidden>
> Reviewed-by: Richard W.M. Jones <address@hidden>
> Tested-by: Richard W.M. Jones <address@hidden>
Ok, will submit tomorrow formally.